Remove Event Interpretation (EI) from relval steps #36465

jfernan2 · 2021-12-13T09:20:50Z

PR description:

As suggested on #32643 and after no response from TOP developers for months, we are safely removing EI from relVal steps

Announced on PPD core meeting 15/12/2021
Slide 13 of https://indico.cern.ch/event/1099504/contributions/4626290/attachments/2364681/4039466/21-12-15_News_PPDCoord.pdf

PR validation:

runTheMatrix.py -l limite -i all --ibeos

wajidalikhan · 2021-12-13T09:25:11Z

Hi @jfernan2, I am not sure if we tagged the relevant people from TOP. I represent TMG (Top Modeling and Generator Group).

jfernan2 · 2021-12-13T09:25:43Z

FYI @ kuyoun

jfernan2 · 2021-12-13T09:27:07Z

@wajidalikhan the list of declared TOP Validators we have is:
https://e-groups.cern.ch/e-groups/Egroup.do?egroupName=cms-dqm-validation-developers-top&tab=3

and only one has a github id declared who does not respond

jfernan2 · 2021-12-13T09:29:24Z

If there are more people related to TOP PAG working in validation please add them on:
https://twiki.cern.ch/twiki/bin/view/CMS/DQMContacts#TOP

cmsbuild · 2021-12-13T09:29:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36465/27317

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update pileup scenario in RelVals #36388, Hydjet++ 2.4.3 integration #36316

cmsbuild · 2021-12-13T09:29:47Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-12-13T09:48:22Z

Adding PF crew since the EI is under their package:
FYI @kdlong @juska @hatakeyamak @chosila @jpata

cmsbuild · 2021-12-13T10:01:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36465/27319

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update pileup scenario in RelVals #36388, Hydjet++ 2.4.3 integration #36316

cmsbuild · 2021-12-13T10:02:14Z

Pull request #36465 was updated. @perrotta, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

jfernan2 · 2021-12-13T10:39:53Z

please test

cmsbuild · 2021-12-13T11:01:59Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3b61b/21214/summary.html
COMMIT: aa50d22
CMSSW: CMSSW_12_3_X_2021-12-12-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36465/21214/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

RelVals

4.534.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
5.15.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

Expand to see more relval errors ...

RelVals-INPUT

4.174.17_RunMinBias2011A+RunMinBias2011A+HLTD+RECODR1reHLT+HARVESTDR1reHLT+SKIMDreHLT/step2_RunMinBias2011A+RunMinBias2011A+HLTD+RECODR1reHLT+HARVESTDR1reHLT+SKIMDreHLT.log
4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
4.264.26_ZMuSkim2011A+ZMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT/step2_ZMuSkim2011A+ZMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT.log

Expand to see more relval errors ...

AddOn Tests

fastsimcmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Dec 13 11:56:13 2021-date Mon Dec 13 11:56:09 2021 s - exit: 256
fastsim1cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Mon Dec 13 11:56:15 2021-date Mon Dec 13 11:56:13 2021 s - exit: 256
fastsim2cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Mon Dec 13 11:56:16 2021-date Mon Dec 13 11:56:14 2021 s - exit: 256

Expand to see more addon errors ...

perrotta · 2022-01-18T17:21:07Z

please test

cmsbuild · 2022-01-18T21:01:12Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3b61b/21778/summary.html
COMMIT: cea0984
CMSSW: CMSSW_12_3_X_2022-01-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36465/21778/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1040 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3464860
DQMHistoTests: Total failures: 4627
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3460210
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-01-19T07:35:17Z

wf 4.76 failed to open input file

hatakeyamak · 2022-01-19T14:52:14Z

Adding PF crew since the EI is under their package: FYI @kdlong @juska @hatakeyamak @chosila @jpata

Thank you for doing this. I don't see a problem with this removal, as long as TOP validators are fine. These use case of EI was not clear not me.

perrotta · 2022-01-24T10:59:23Z

+operations

Output changes consist in the removal of the EI related quantities, some reshuffling of the HLT paths, and kind of expected changes in top, ET, and related monitorings

cmsbuild · 2022-01-24T10:59:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-24T11:00:34Z

+1

perrotta · 2022-01-24T11:00:57Z

merge

cmsbuild added this to the CMSSW_12_3_X milestone Dec 13, 2021

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Dec 13, 2021

jfernan2 mentioned this pull request Dec 13, 2021

Should we remove EventInterpretation step out from relval? #32643

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 13, 2021

cmsbuild added code-checks-pending operations-pending and removed code-checks-approved labels Dec 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 13, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 13, 2021

cmsbuild added tests-rejected and removed tests-started labels Dec 13, 2021

cmsbuild added core-approved and removed core-pending labels Jan 18, 2022

cmsbuild added tests-started and removed tests-approved labels Jan 18, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2022

cmsbuild mentioned this pull request Jan 19, 2022

ECAL Phase 2 Development WF 28234.61 fix #36748

Merged

This was referenced Jan 19, 2022

Add hgcalv16 modifier and corresponding era #36753

Merged

Drop type specs for DQMOffline/Trigger #36783

Closed

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Jan 24, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 24, 2022

cmsbuild merged commit eee1640 into cms-sw:master Jan 24, 2022

perrotta mentioned this pull request Mar 14, 2022

MiniAOD warnings in 12_4_0_pre1 using 2021 data #37227

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Event Interpretation (EI) from relval steps #36465

Remove Event Interpretation (EI) from relval steps #36465

jfernan2 commented Dec 13, 2021 •

edited

Loading

wajidalikhan commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

jfernan2 commented Dec 13, 2021 •

edited

Loading

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

perrotta commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

jfernan2 commented Jan 19, 2022

hatakeyamak commented Jan 19, 2022 •

edited

Loading

perrotta commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

perrotta commented Jan 24, 2022

perrotta commented Jan 24, 2022

Remove Event Interpretation (EI) from relval steps #36465

Remove Event Interpretation (EI) from relval steps #36465

Conversation

jfernan2 commented Dec 13, 2021 • edited Loading

PR description:

PR validation:

wajidalikhan commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

jfernan2 commented Dec 13, 2021 • edited Loading

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

jfernan2 commented Dec 13, 2021

cmsbuild commented Dec 13, 2021

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

perrotta commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

RelVals-INPUT

Comparison Summary

jfernan2 commented Jan 19, 2022

hatakeyamak commented Jan 19, 2022 • edited Loading

perrotta commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

perrotta commented Jan 24, 2022

perrotta commented Jan 24, 2022

jfernan2 commented Dec 13, 2021 •

edited

Loading

jfernan2 commented Dec 13, 2021 •

edited

Loading

hatakeyamak commented Jan 19, 2022 •

edited

Loading