-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Event Interpretation (EI) from relval steps #36465
Conversation
Hi @jfernan2, I am not sure if we tagged the relevant people from TOP. I represent TMG (Top Modeling and Generator Group). |
FYI @ kuyoun |
@wajidalikhan the list of declared TOP Validators we have is: and only one has a github id declared who does not respond |
If there are more people related to TOP PAG working in validation please add them on: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36465/27317
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Adding PF crew since the EI is under their package: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36465/27319
|
Pull request #36465 was updated. @perrotta, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
please test |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
wf 4.76 failed to open input file |
Thank you for doing this. I don't see a problem with this removal, as long as TOP validators are fine. These use case of EI was not clear not me. |
+operations
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
As suggested on #32643 and after no response from TOP developers for months, we are safely removing EI from relVal steps
Announced on PPD core meeting 15/12/2021
Slide 13 of https://indico.cern.ch/event/1099504/contributions/4626290/attachments/2364681/4039466/21-12-15_News_PPDCoord.pdf
PR validation:
runTheMatrix.py -l limite -i all --ibeos