Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation/RecoEgamma Code simplification v1 #36393

Merged
merged 9 commits into from
Dec 9, 2021

Conversation

archiron
Copy link
Contributor

@archiron archiron commented Dec 7, 2021

PR description:

Here we made some simplification especially with the nimber of "if" tests. We rewite the tests in order to reduce the number but in order to keep the physical presentation into the .CC files.

Some additional update for theconfig test script into the test folder have been made.
there are no expected changes.

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (39 38 37 28 18 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@beaudett

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36393/27192

  • This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36393/27193

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

  • Validation/RecoEgamma (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc1cc4/21075/summary.html
COMMIT: 384e7d1
CMSSW: CMSSW_12_3_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36393/21075/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250560
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250532
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.856 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -0.062 KiB EgammaV/ElectronMcSignalValidatorPt1000
  • DQMHistoSizes: changed ( 10024.0,... ): -0.057 KiB EgammaV/ElectronMcSignalValidator
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 8, 2021

@archiron there are some small changes in some workflows:
https://tinyurl.com/y3jz73hn
https://tinyurl.com/y5lhd4bj
Entries are reduced w.r.t. old (blue), is it expected?
All changes here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2021-12-07-1100+fc1cc4/47318/dqm-histo-comparison-summary.html

move h1_ele_ecalEnergyError_barrel->Fill(bestGsfElectron.correctedEcalEnergyError()); line which was in isEEflag test instead of isEBflag test.
@archiron
Copy link
Contributor Author

archiron commented Dec 8, 2021

there was a small bug :
the h1_ele_ecalEnergyError_barrel->Fill(bestGsfElectron.correctedEcalEnergyError()); line which was in isEEflag test instead of isEBflag test.
I think there is no pbm now.

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36393/27230

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

Pull request #36393 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc1cc4/21094/summary.html
COMMIT: 30ff4ce
CMSSW: CMSSW_12_3_X_2021-12-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36393/21094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250560
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250526
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.856 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -0.062 KiB EgammaV/ElectronMcSignalValidatorPt1000
  • DQMHistoSizes: changed ( 10024.0,... ): -0.057 KiB EgammaV/ElectronMcSignalValidator
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants