-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDC simulation for HFQIE10 (12_1) #35308
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35308/25324
|
A new Pull Request was created by @mseidel42 (Markus Seidel) for master. It involves the following packages:
@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Are the MC hits with TDC=31 expected? These don't seem to occur in data. |
Those are the special codes, just divided by 2 to compare with the data plot (ns instead of TDC). cmssw/SimCalorimetry/HcalSimAlgos/interface/HcalTDCParameters.h Lines 12 to 15 in a87b522
|
@cmsbuild , please abort |
test parameters:
|
@cmsbuild , please test |
@tvami for future reference, workflows in the short matrix are always tested, so it's not necessary to specify them explicitly. |
@kpedro88 I had a look at another PR to see what's included |
Easier to check cmssw/Configuration/PyReleaseValidation/scripts/runTheMatrix.py Lines 61 to 100 in 04e25fa
Indeed, maybe a Run3 PU workflow should be considered for regular testing. |
@toropin @igv4321 There is HFPhase1PMTParams_2017_v1.0_mc tag since 2016 in all the MC GTs |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29891e/18672/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35308/25448
|
Pull request #35308 was updated. @malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please check and sign again. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29891e/18839/summary.html Comparison SummarySummary:
|
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Tested with workflows 11634.0 (Run3 ttbar), 11834.0 (Run3 ttbar+PU), 250202.181 (Run2 ttbar+premix PU), no "Mismatched calo signals" messages.
MC Run3 ttbar+PU:
MC Run2 ttbar+premix PU (time alignment for Run2 MC is a little off, keep frozen):
Run2 data:
@abdoulline @kpedro88 @tvami