Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_0_X] Add SiStripCalCosmics ALCANANO #35306

Merged

Conversation

pieterdavid
Copy link
Contributor

PR description:

This PR adds a SiStripCalCosmicsNano ALCARECO, which is SiStripCalCosmics in NanoAOD format (also known as ALCANANO); it is a backport for testing during the upcoming CRAFT run, see the discussion in the original PR #34985 (comment) .

PR validation:

Compiles, scram b runtests and runTheMatrix.py -l 138.1 run. The only conflict in the rebase was with the changes from #35073 and trivial to resolve.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34985

CC: @robervalwalsh @mdelcourt @ataliercio @jandrejk @mmusich @tsusa @mariadalfonso @gouskos

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2021

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_12_0_X.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • Configuration/Applications (operations)
  • Configuration/DataProcessing (operations)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/NanoAOD (xpog)

@perrotta, @malbouis, @gouskos, @jordan-martins, @davidlange6, @chayanit, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @yuanchao, @fgolf, @kskovpen, @qliphy, @mariadalfonso, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @robervalwalsh, @kpedro88, @Martin-Grunewald, @threus, @mmusich, @slomeo, @makortel, @JanFSchulte, @dgulhan, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @swertz, @gbenelli, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2021

test parameters:

  • workflows = 7.2, 7.21, 7.22, 7.23, 7.24, 7.3, 7.4, 134.813, 136.733, 138.1, 138.2

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2021

@cmsbuild, please test

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

backport of #34985

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3c7e2/18668/summary.html
COMMIT: 545b041
CMSSW: CMSSW_12_0_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35306/18668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/136.733_RunCosmics2016B+RunCosmics2016B+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/138.2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c3c7e2/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

+alca

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

urgent

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

urgent

@kskovpen @srimanob @mariadalfonso we'd like this to be included in the CRAFT, please sign at your earliest convenience

@mariadalfonso
Copy link
Contributor

+xpog
changes in PhysicsTools/NanoAOD/test/inspectNanoFile.py inline with master

@bbilin
Copy link
Contributor

bbilin commented Sep 16, 2021

+1

@srimanob
Copy link
Contributor

+Upgrade

This is a backport PR.

@qliphy
Copy link
Contributor

qliphy commented Sep 19, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 72921c7 into cms-sw:CMSSW_12_0_X Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants