DQM Pixel Phase 1: Several new Efficiency trend plots #34384

SissonJ · 2021-07-07T14:35:08Z

Additions to DQM/SiPixelPhase1
Added new trend plots:

Efficiency vs LS: Barrel & Endcap -- new specification in SiPixelPhase1Track
Efficiency vs Mean number of vertices: Barrel & Endcap -- new DQMEDHarvester in SiPixelPhase1Track
Efficiency vs Instantaneous Luminosity: Barrel & Endcap -- new DQMEDHarvester in SiPixelPhase1Track

Related talks:
https://indico.cern.ch/event/1000808/contributions/4355849/attachments/2241277/3800219/TrackerDQM5_7_21.pdf
https://indico.cern.ch/event/934813/contributions/4103234/attachments/2142978/3611403/PixelEfficiencyTrendPlots_111320.pdf

Tested with runTheMatrix.py -l 136.892
Tested missing lumiVsLS protection with fake HLT runTheMatrix

cmsbuild · 2021-07-07T14:48:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-07T15:39:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23775

This PR adds an extra 36KB to repository

cmsbuild · 2021-07-07T15:39:32Z

A new Pull Request was created by @SissonJ (Jack Sisson) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Config
DQM/SiPixelPhase1Track

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-07-07T15:54:59Z

DQM/SiPixelPhase1Common/src/HistogramManager.cc

@@ -546,6 +541,7 @@ void HistogramManager::executePerLumiHarvesting(DQMStore::IBooker& iBooker,
 }

 void HistogramManager::loadFromDQMStore(SummationSpecification& s, Table& t, DQMStore::IGetter& iGetter) {
+  //std::cout << "Running the loadFromDQMStore function" << std::endl;


part of the debugging changes? Perhaps to remove?

jfernan2 · 2021-07-07T15:59:44Z

DQM/SiPixelPhase1Config/python/SiPixelPhase1OfflineDQM_source_cff.py

 #Barycenter plots
 from DQM.SiPixelPhase1Summary.SiPixelBarycenter_cfi import *

 from RecoPixelVertexing.PixelLowPtUtilities.ClusterShapeHitFilterESProducer_cfi import *
 from RecoLocalTracker.SiStripClusterizer.SiStripClusterChargeCut_cfi import *

+


The cfi is importing the module but SiPixelPhase1EfficiencyExtras is not added to the sequence, is this intentional?

Everything in OfflineDQM_source_cff is imported to OfflineDQM_harvesting_cff:
from DQM.SiPixelPhase1Config.SiPixelPhase1OfflineDQM_source_cff import *

The sequence this module appears in is: siPixelPhase1OfflineDQM_harvesting

jfernan2 · 2021-07-07T16:01:08Z

DQM/SiPixelPhase1Config/python/SiPixelPhase1OnlineDQM_cff.py

@@ -97,6 +92,7 @@
 + SiPixelPhase1TrackResidualsHarvester
 + RunQTests_online
 + SiPixelPhase1SummaryOnline
+ + SiPixelPhase1EfficiencyExtras


Since this is affecting Online DQM but we cannot test it at present at P5 because it runs 11_3_X, have you tested it on your side too? When would you need these plots in Online, for CRAFT in August? Thanks

Checking with group conveners. Our development was in 11_1_X, but we haven't explicitly tested Online. The plots are not urgent for CRAFT.

@jfernan2 in principle this can wait till CRAFT. Jacob is testing with the online client privately now.

OK thanks. I was asking because this PR is in 12_0_X and 12_0_0 should be ready by the end of August, since CMSSW_12_0_0 is expected to be used in the LHC beam test scheduled by the last week of September. So I am afraid that not for CRAFT...

I guess we should just backport it, no?

@jfernan2 Removed this Harvester from online since it is only needed in offline!

cmsbuild · 2021-07-07T16:04:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23778

This PR adds an extra 36KB to repository

cmsbuild · 2021-07-07T16:04:24Z

Pull request #34384 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

mmusich · 2021-07-07T17:30:34Z

please test

mmusich · 2021-07-07T17:31:42Z

DQM/SiPixelPhase1Track/plugins/SiPixelPhase1EfficiencyExtras.cc

+     <Notes on implementation>
+*/
+//
+// Original Author:  Duncan Leggat


@SissonJ is this accurate?

cmsbuild · 2021-08-27T16:12:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/24920

This PR adds an extra 16KB to repository

cmsbuild · 2021-08-27T16:12:35Z

Pull request #34384 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

mmusich · 2021-08-27T16:21:17Z

please test

cmsbuild · 2021-08-27T20:37:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d208a8/18099/summary.html
COMMIT: 6c4b2f0
CMSSW: CMSSW_12_1_X_2021-08-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34384/18099/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 7980.553 KiB( 38 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 613.889 KiB PixelPhase1/Tracks
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-08-28T08:15:18Z

+1

cmsbuild · 2021-08-28T08:15:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-08-30T01:15:55Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone Jul 7, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 7, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 7, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 7, 2021

jfernan2 reviewed Jul 7, 2021

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Jul 7, 2021

jfernan2 reviewed Jul 7, 2021

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 7, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 7, 2021

mmusich reviewed Jul 7, 2021

View reviewed changes

cmsbuild removed code-checks-approved tests-started labels Jul 7, 2021

cmsbuild added code-checks-pending dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-approved code-checks-approved labels Aug 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 27, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 28, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 30, 2021

cmsbuild merged commit 3ad0e16 into cms-sw:master Aug 30, 2021

cmsbuild mentioned this pull request Aug 30, 2021

Updated root to tip of branch v6-24-00-patches cms-sw/cmsdist#7251

Merged

perrotta mentioned this pull request Sep 1, 2021

Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

SissonJ commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

jfernan2 Jul 7, 2021

SissonJ Jul 7, 2021

jfernan2 Jul 7, 2021

SissonJ Jul 7, 2021

jfernan2 Jul 7, 2021

SissonJ Jul 7, 2021

sroychow Jul 7, 2021

jfernan2 Jul 7, 2021

mmusich Jul 7, 2021

SissonJ Jul 16, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

mmusich commented Jul 7, 2021

mmusich Jul 7, 2021

SissonJ Jul 7, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

mmusich commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

jfernan2 commented Aug 28, 2021

cmsbuild commented Aug 28, 2021

qliphy commented Aug 30, 2021

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

Conversation

SissonJ commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

mmusich commented Jul 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

mmusich commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

Comparison Summary

jfernan2 commented Aug 28, 2021

cmsbuild commented Aug 28, 2021

qliphy commented Aug 30, 2021