Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackingPhase1PU70 customizations as obsolete #18564

Merged
merged 3 commits into from
May 9, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented May 4, 2017

This PR (finally!) cleans up the long-obsolete trackingPhase1PU70 era customizations. In addition I did further cleanup in the iterative tracking configurations, most notably made the trackingPhase1 parameters the defaults in LowPtQuadStep, DetachedQuadStep, and HighPtTripletStep.

Tested in 9_1_0_pre2, no changes expected.

@rovere @VinInn @ebrondol

Make trackingPhase1 configurations the defaults in LowPtQuad,
HighPtTriplet, DetachedQuad that are specific to phase1/phase2.
@makortel
Copy link
Contributor Author

makortel commented May 4, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19565/console Started: 2017/05/04 13:35

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
RecoJets/JetProducers
RecoMuon/Configuration
RecoPixelVertexing/Configuration
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelTriplets
RecoTracker/ConversionSeedGenerators
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking
RecoTracker/TkHitPairs
RecoTracker/TkSeedGenerator
RecoTracker/TkSeedingLayers
RecoTracker/TkTrackingRegions
Validation/RecoTrack
Validation/RecoVertex

@perrotta, @dmitrijus, @cmsbuild, @franzoni, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @yslai, @felicepantaleo, @abbiendi, @rappoccio, @Martin-Grunewald, @venturia, @battibass, @ahinzmann, @jhgoh, @jdolen, @HuguesBrun, @trocino, @schoef, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @nhanvtran, @gkasieczka, @wmtford, @mschrode, @ebrondol, @mtosi, @dgulhan, @echapon, @calderona, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

-1

Tested at: f66e998

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18564/19565/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu May 4 14:49:45 2017-date Thu May 4 14:41:31 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu May 4 14:49:40 2017-date Thu May 4 14:41:37 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu May 4 14:50:05 2017-date Thu May 4 14:42:12 2017 s - exit: 16640

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@smuzaffar smuzaffar modified the milestones: CMSSW_9_2_X, CMSSW_9_1_X May 4, 2017
@makortel
Copy link
Contributor Author

makortel commented May 4, 2017

Found a problem in sequence definitions, will push a fix after local tests finish.

(didn't catch earlier because of matrix tests being unscheduled, and apparently the addOnTests reco jobs are run in scheduled mode)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18564/19565/summary.html

Comparison Summary:

  • You potentially added 80 lines to the logs
  • Reco comparison results: 3366 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1788832
  • DQMHistoTests: Total failures: 16571
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1772081
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 95 log files, 14 edm output root files, 24 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Pull request #18564 was updated. @perrotta, @dmitrijus, @cmsbuild, @franzoni, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented May 5, 2017

@cmsbuild, please test

That should fix the sequences.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19587/console Started: 2017/05/05 10:13

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18564/19587/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1700 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 41879
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1788991
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@VinInn
Copy link
Contributor

VinInn commented May 8, 2017

ping, essentially no work on tracker related config is possible till this PR is merged

@perrotta
Copy link
Contributor

perrotta commented May 9, 2017

+1

  • trackingPhase1PU70 customizations removed; trackingPhase1 parameters set as defaults in LowPtQuadStep, DetachedQuadStep, and HighPtTripletStep
  • No changes expected in std workflows: no changes observed in jenkins outputs, nor in some larger stat test run in order to check that there no issues sorted out when setting different defaults (there are so many places in which it was done that I did not want to trust only my attentiveness during the visual inspection...)

@davidlange6 davidlange6 merged commit 6ee7ba9 into cms-sw:master May 9, 2017
@makortel makortel deleted the removeTrackingPhase1PU70 branch February 12, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants