Allow stacktrace handler to timeout. #11662
Conversation
This corrects a few issues: - Stacktrace handler thread will set the SIGABRT and friends handler to SIG_DFL. Avoids a potential deadlock. - Primary signal handler will timeout after 5 minutes of waiting for the stacktrace handler thread to return (timeout hardcoded for now). - Do NOT call execv: libsnoopy at CERN replaces the async-signal-safe POSIX function with a non-async-signal-safe variant which can cause deadlocks. Instead, invoke the syscall directly (only on Linux).
|
A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_6_X. Allow stacktrace handler to timeout. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
@Dr15Jones - I assume a backport is reasonable for 7.4 and 7.5 if this passes IBs with flying colors? |
|
+1 |
Allow stacktrace handler to timeout.
|
@bbockelm Which ever releases we switch out the ROOT handler for your new one we will need back porch this change to as well. |
This corrects a few issues:
to SIG_DFL. Avoids a potential deadlock.
the stacktrace handler thread to return (timeout hardcoded for now).
POSIX function with a non-async-signal-safe variant which can cause
deadlocks. Instead, invoke the syscall directly (only on Linux).