-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we use PROOF? #43975
Comments
assign core |
New categories assigned: core @Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
type root |
cms-bot internal usage |
A new Issue was created by @iarspider . @makortel, @smuzaffar, @sextonkennedy, @rappoccio, @Dr15Jones, @antoniovilela can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
I'm OK with dropping PROOF support. I don't know of anyone who ever used our extra code built on top of PROOF. |
I agree with dropping it, I think PROOF has been passed by in favor of other developments. |
I'm fine with dropping it, but maybe we should announce it somewhere? (just to make sure) |
agree. Is announcing it on SW development forum enough? |
We could hope so :) (i.e. I don't have a better forum to suggest) |
Drop PROOF tests (as discussed in #43975)
PROOF tests were removed in #43996 |
The removal was announced in https://cms-talk.web.cern.ch/t/removal-of-roots-proof-in-the-future/34915 |
Do we already have a cmsdist PR that drops the PROOF from ROOT? |
@makortel kind of: cms-sw/cmsdist#8999 . Or should I make PR(s) to explicitly disable PROOF in branches where it is enabled by default? |
No, I think the cmsdist PR of ROOT update (where they changed the default) does the job (and follows what your announcement message). I just wanted to record the cmsdist PR here. |
+core |
@cmsbuild, please close |
This issue is fully signed and ready to be closed. |
In root-project/root#14513, PROOF was made optional (off by default), causing test failures when testing new ROOT master version: link.
However, it is only used by two tests:
FWCore/TFWLiteSelector/test/proof_thing_sel.C and FWCore/TFWLiteSelector/test/proof_thing2_sel.C.
Should we explicitly enable PROOF, or should we drop these two tests?
The text was updated successfully, but these errors were encountered: