Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVEL] drop -Wno-deprecated and -Wno-deprecated-copy flags #8766

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/devel.

@smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals

lets get this in DEVEL IBs, this will end up a lot of warnings for deprecated-copy .

@smuzaffar smuzaffar merged commit 1da330c into IB/CMSSW_13_3_X/devel Oct 18, 2023
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af33b8/35248/summary.html
COMMIT: b504369
CMSSW: CMSSW_13_3_DEVEL_X_2023-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8766/35248/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af33b8/35248/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af33b8/35248/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 124 lines from the logs
  • Reco comparison results: 62641 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 155151
  • DQMHistoTests: Total nulls: 269
  • DQMHistoTests: Total successes: 3201958
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.10599999999999998 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12634.0 ): 0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.978 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.564 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 18 / 48 workflows

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/devel IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch October 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants