Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove py3-google-common package #7240

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

iarspider
Copy link
Contributor

google-common is no longer needed for Python >= 3.3: https://packaging.python.org/guides/packaging-namespace-packages/

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

@iarspider , please also drop

Requires: py3-googlePackages

@iarspider
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

Pull request #7240 was updated.

@smuzaffar
Copy link
Contributor

also add py3-protobuf in to python tools

@cmsbuild
Copy link
Contributor

Pull request #7240 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4d79c/18030/summary.html
COMMIT: cc12e33
CMSSW: CMSSW_12_1_X_2021-08-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7240/18030/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #7240 was updated.

@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

+externals
looks good

[email protected]>python3
iPython 3.9.6 (default, Jul 28 2021, 18:12:51)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from google import protobuf
>>> protobuf.__file__
'/cvmfs/cms-ci.cern.ch/week1/PR_6cbf53ed/slc7_amd64_gcc900/external/py3-protobuf/3.15.1-dhcijl/lib/python3.9/site-packages/google/protobuf/__init__.py'
>>> from google import auth
>>> auth.__file__
'/cvmfs/cms-ci.cern.ch/week1/PR_6cbf53ed/slc7_amd64_gcc900/external/py3-google-auth/1.27.0-llifpc2/lib/python3.9/site-packages/google/auth/__init__.py'
>>>

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4d79c/18031/summary.html
COMMIT: dab550d
CMSSW: CMSSW_12_1_X_2021-08-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7240/18031/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4d79c/18031/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4d79c/18031/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000330
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants