Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #6997

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 8, 2021

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/summary.html
COMMIT: ad0e007
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6997/15747/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648335
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648306
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@slava77 , Can you please check the reco comparison changes here https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_ROOT6_X_2021-06-07-2300+28b4d8/43295/validateJR.html ?

@mrodozov , we need to understand the comparison diff before we integrate this.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/summary.html
COMMIT: ad0e007
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6997/15854/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2862485
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #6997 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/summary.html
COMMIT: 7c0ebe0
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6997/15937/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test GeometryDOMCount had ERRORS
---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

we still have 7 reco comparison differences , we ned to understand why these are there.
@slava77 can you please give it a look

@slava77
Copy link
Contributor

slava77 commented Jun 14, 2021

we still have 7 reco comparison differences , we ned to understand why these are there.
@slava77 can you please give it a look

the differences are all in ctppsProtons error/uncertainty plot, e.g. in 136.874
all_OldVSNew_RunEGamma2018Cwf136p874c_log10recoForwardProtons_ctppsProtons_multiRP_reRECO_obj_xiError

it could be an artifact of how these plots are made. The script loads the old file first; if the new file has a different format/streaming, the plots may look wrong. I can't recall if we have any other plots from SMatrix data members, perhaps absence of other differences indicates that this is specific to SMatrix. cms-sw/root@817af6f...4ac5a62 is not particularly revealing.

@jan-kaspar @fabferro
is this collection and variable monitored in DQM?
If monitored, the lack of differences in the DQM plots should validate this PR.

@smuzaffar
Copy link
Contributor

@jan-kaspar @fabferro @cms-sw/dqm-l2 , can you please look in to DQM plots ( as suggested here #6997 (comment) )

@jfernan2
Copy link

@smuzaffar the DQM bin by bin tool does not see those changes on CTPPS for 136.874 or any other wf

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_ROOT6_X_2021-06-13-2300+28b4d8/43446/dqm-histo-comparison-summary.html

All changes seen are in */EventInfo/CMSSW_Version as expected

I let @jan-kaspar and @fabferro to comment on the CTPPS details

@smuzaffar
Copy link
Contributor

as dqm bin by bin comparisonm are not seeing these diff. So lets merge this and go ahead with next root master update

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 8067c5a into cms-sw:IB/CMSSW_12_0_X/rootmaster Jun 21, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants