Updated root to tip of branch master

[mrodozov]

No description provided.

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/summary.html
COMMIT: ad0e007
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6997/15747/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• update CrabClient version in dev #6995 @belforte: update CrabClient version in dev

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15747/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648335
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648306
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@slava77 , Can you please check the reco comparison changes here https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_ROOT6_X_2021-06-07-2300+28b4d8/43295/validateJR.html ?

@mrodozov , we need to understand the comparison diff before we integrate this.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/summary.html
COMMIT: ad0e007
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6997/15854/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Oracle: update instantclient 19.11 #6986 @cms-sw: Oracle: update instantclient 19.11
• Update pillow to 8.2.0 to fix the security issue reported by GH #7005 @cms-sw: Update pillow to 8.2.0 to fix the security issue reported by GH
• [DXR] Py3 updates needed to avoid creashes with multi-threading #7004 @cms-sw: [DXR] Py3 updates needed to avoid creashes with multi-threading
• [DXR] Added deps on py3-Pygments which is required at runtime by dxr #7007 @cms-sw: [DXR] Added deps on py3-Pygments which is required at runtime by dxr
• [BuildRules] Fix issue with generating rootmap files during PR tests #7006 @cms-sw: [BuildRules] Fix issue with generating rootmap files during PR tests

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15854/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mrodozov]

please test

[cmsbuild]

Pull request #6997 was updated.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/summary.html
COMMIT: 7c0ebe0
CMSSW: CMSSW_12_0_ROOT6_X_2021-06-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6997/15937/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• updated DetectorDescription-Schema=V02-03-00 #7025 @cms-sw: updated DetectorDescription-Schema=V02-03-00
• move tested dev to prod #7024 @belforte: move tested dev to prod

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28b4d8/15937/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test GeometryDOMCount had ERRORS
---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

we still have 7 reco comparison differences , we ned to understand why these are there.
@slava77 can you please give it a look

[slava77]

we still have 7 reco comparison differences , we ned to understand why these are there.
@slava77 can you please give it a look

the differences are all in ctppsProtons error/uncertainty plot, e.g. in 136.874

it could be an artifact of how these plots are made. The script loads the old file first; if the new file has a different format/streaming, the plots may look wrong. I can't recall if we have any other plots from SMatrix data members, perhaps absence of other differences indicates that this is specific to SMatrix. cms-sw/root@817af6f...4ac5a62 is not particularly revealing.

@jan-kaspar @fabferro
is this collection and variable monitored in DQM?
If monitored, the lack of differences in the DQM plots should validate this PR.

[smuzaffar]

@jan-kaspar @fabferro @cms-sw/dqm-l2 , can you please look in to DQM plots ( as suggested here #6997 (comment) )

[jfernan2]

@smuzaffar the DQM bin by bin tool does not see those changes on CTPPS for 136.874 or any other wf

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_ROOT6_X_2021-06-13-2300+28b4d8/43446/dqm-histo-comparison-summary.html

All changes seen are in */EventInfo/CMSSW_Version as expected

I let @jan-kaspar and @fabferro to comment on the CTPPS details

[smuzaffar]

as dqm bin by bin comparisonm are not seeing these diff. So lets merge this and go ahead with next root master update

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)