update mkfit to 3.0.1 #6917

slava77 · 2021-05-17T15:02:47Z

A new release of mkfit is now available
https://github.com/trackreco/mkFit/releases/tag/V3.0.0-0%2Bpr315

this cmsdist PR still needs a matching PR in cms-sw/cmssw

cmsbuild · 2021-05-17T15:03:13Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

cmsbuild · 2021-05-17T16:06:03Z

Pull request #6917 was updated.

cmsbuild · 2021-05-20T23:15:00Z

Pull request #6917 was updated.

smuzaffar · 2021-05-21T04:56:20Z

please test with cms-sw/cmssw#33802

cmsbuild · 2021-05-21T05:40:41Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15225/summary.html
COMMIT: 3632e85
CMSSW: CMSSW_12_0_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6917/15225/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitOutputConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: nlohmann/json_fwd.hpp: No such file or directory
    6 | #include "nlohmann/json_fwd.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: nlohmann/json_fwd.hpp: No such file or directory

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitOutputConverter.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: 'nlohmann/json_fwd.hpp' file not found
#include "nlohmann/json_fwd.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: 'nlohmann/json_fwd.hpp' file not found

cmsbuild · 2021-05-21T06:01:24Z

Pull request #6917 was updated.

smuzaffar · 2021-05-21T06:01:42Z

please test with cms-sw/cmssw#33802

makortel · 2021-06-07T14:03:03Z

@cmsbuild, please test with cms-sw/cmssw#33802

cmsbuild · 2021-06-07T21:17:44Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15720/summary.html
COMMIT: bff911f
CMSSW: CMSSW_12_0_X_2021-06-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15720/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update vecgeom to 1.1.16 #6975 @cms-sw: Update vecgeom to 1.1.16

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15720/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15720/git-merge-result

RelVals-INPUT

11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648335
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2648306
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jpata · 2021-06-08T10:58:47Z

is this a problem of the PR or of the test (also for the main PR cms-sw/cmssw#33802)?

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02684/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-06-0000/bin/slc7_amd64_gcc900/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02684/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-06-0000/bin/slc7_amd64_gcc900/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 2301, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 891, in addCustomise
    __import__(packageName)
  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15720/CMSSW_12_0_X_2021-06-06-2300/python/RecoTracker/MkFit/customizeHLTIter0ToMkFit.py", line 4, in <module>
    import RecoTracker.MkFit.mkFitHitConverter_cfi as mkFitHitConverter_cfi
  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15720/CMSSW_12_0_X_2021-06-06-2300/python/RecoTracker/MkFit/mkFitHitConverter_cfi.py", line 3, in <module>
    from RecoTracker.MkFit.mkFitHitConverterDefault_cfi import mkFitHitConverterDefault as _mkFitHitConverterDefault
ImportError: No module named mkFitHitConverterDefault_cfi

makortel · 2021-06-08T12:56:48Z

It is a problem in cms-sw/cmssw#33802 for which I'll submit a fix soon.

makortel · 2021-06-08T14:09:59Z

@cmsbuild, please test with cms-sw/cmssw#33802

makortel · 2021-06-09T01:23:05Z

Comparisons seem to be stuck, and I was thinking launching tests anyway from cmssw side now that code-checks there succeeded

qliphy · 2021-06-16T15:49:12Z

tested with cms-sw/cmssw#33802

qliphy · 2021-06-16T15:49:23Z

+1

qliphy · 2021-06-16T15:49:30Z

merge

cmsbuild · 2021-06-16T15:49:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15762/summary.html
COMMIT: bff911f
CMSSW: CMSSW_12_0_X_2021-06-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15762/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

update CrabClient version in dev #6995 @belforte: update CrabClient version in dev
Update tag for PhysicsTools-PatUtils to V00-05-00 #6998 @cms-sw: Update tag for PhysicsTools-PatUtils to V00-05-00
Updated root to tip of branch v6-22-00-patches #6991 @mrodozov: Updated root to tip of branch v6-22-00-patches

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15762/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15762/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648335
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2648312
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

update mkfit to 3.0.0

bf9077c

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels May 17, 2021

BUILD_ARGS=SSE3="1" for x86_64 is a better choice

2ac363a

Update mkfit.spec

3632e85

slava77 changed the title ~~update mkfit to 3.0.0~~ update mkfit to 3.0.1 May 20, 2021

makortel mentioned this pull request May 21, 2021

Update MkFit to support multiple iterations cms-sw/cmssw#33802

Merged

slava77 marked this pull request as ready for review May 21, 2021 00:53

cmsbuild added requires-external tests-started tests-rejected and removed tests-pending tests-started labels May 21, 2021

mkfit now use nlohmann/json

bff911f

cmsbuild added tests-pending and removed requires-external tests-rejected labels May 21, 2021

cmsbuild added requires-external tests-started and removed tests-pending tests-started labels May 21, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 7, 2021

cmsbuild added tests-started and removed tests-rejected labels Jun 7, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 7, 2021

cmsbuild added tests-started tests-pending and removed tests-rejected tests-started labels Jun 8, 2021

cmsbuild added orp-approved tests-approved and removed orp-pending tests-pending labels Jun 16, 2021

cmsbuild merged commit 89bad08 into cms-sw:IB/CMSSW_12_0_X/master Jun 16, 2021

cmsbuild added tests-started and removed tests-approved labels Jun 16, 2021

cms-sw deleted a comment from makortel Jun 16, 2021

This was referenced Jun 16, 2021

remove py2-scipy #7034

Merged

[G4][geant4_only] Update geant4 to 10.7.2 #7042

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update mkfit to 3.0.1 #6917

update mkfit to 3.0.1 #6917

slava77 commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 20, 2021

smuzaffar commented May 21, 2021

cmsbuild commented May 21, 2021

cmsbuild commented May 21, 2021

smuzaffar commented May 21, 2021

makortel commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

jpata commented Jun 8, 2021

makortel commented Jun 8, 2021

makortel commented Jun 8, 2021

makortel commented Jun 9, 2021

qliphy commented Jun 16, 2021

qliphy commented Jun 16, 2021

qliphy commented Jun 16, 2021

cmsbuild commented Jun 16, 2021

update mkfit to 3.0.1 #6917

update mkfit to 3.0.1 #6917

Conversation

slava77 commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 20, 2021

smuzaffar commented May 21, 2021

cmsbuild commented May 21, 2021

Build

Clang Build

cmsbuild commented May 21, 2021

smuzaffar commented May 21, 2021

makortel commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

RelVals-INPUT

Comparison Summary

jpata commented Jun 8, 2021

makortel commented Jun 8, 2021

makortel commented Jun 8, 2021

makortel commented Jun 9, 2021

qliphy commented Jun 16, 2021

qliphy commented Jun 16, 2021

qliphy commented Jun 16, 2021

cmsbuild commented Jun 16, 2021

Comparison Summary