-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mkfit to 3.0.1 #6917
update mkfit to 3.0.1 #6917
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
Pull request #6917 was updated. |
Pull request #6917 was updated. |
please test with cms-sw/cmssw#33802 |
-1 Failed Tests: Build ClangBuild BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitOutputConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: nlohmann/json_fwd.hpp: No such file or directory 6 | #include "nlohmann/json_fwd.hpp" | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: nlohmann/json_fwd.hpp: No such file or directory Clang BuildI found compilation error while trying to compile with clang. Command used:
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/MkFitOutputConverter.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: 'nlohmann/json_fwd.hpp' file not found #include "nlohmann/json_fwd.hpp" ^~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-20-2300/src/RecoTracker/MkFit/plugins/createCMS2017.cc:8: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.0.1-dc4ee8ee7cd4b714a60109f026756d49/include/mkFit/IterationConfig.h:6:10: fatal error: 'nlohmann/json_fwd.hpp' file not found |
Pull request #6917 was updated. |
please test with cms-sw/cmssw#33802 |
@cmsbuild, please test with cms-sw/cmssw#33802 |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-INPUT
Comparison SummarySummary:
|
is this a problem of the PR or of the test (also for the main PR cms-sw/cmssw#33802)? Traceback (most recent call last):
File "/cvmfs/cms-ib.cern.ch/nweek-02684/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-06-0000/bin/slc7_amd64_gcc900/cmsDriver.py", line 56, in <module>
run()
File "/cvmfs/cms-ib.cern.ch/nweek-02684/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-06-0000/bin/slc7_amd64_gcc900/cmsDriver.py", line 28, in run
configBuilder.prepare()
File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 2301, in prepare
self.pythonCfgCode += self.addCustomise()
File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-06-2300/python/Configuration/Applications/ConfigBuilder.py", line 891, in addCustomise
__import__(packageName)
File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15720/CMSSW_12_0_X_2021-06-06-2300/python/RecoTracker/MkFit/customizeHLTIter0ToMkFit.py", line 4, in <module>
import RecoTracker.MkFit.mkFitHitConverter_cfi as mkFitHitConverter_cfi
File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6917/15720/CMSSW_12_0_X_2021-06-06-2300/python/RecoTracker/MkFit/mkFitHitConverter_cfi.py", line 3, in <module>
from RecoTracker.MkFit.mkFitHitConverterDefault_cfi import mkFitHitConverterDefault as _mkFitHitConverterDefault
ImportError: No module named mkFitHitConverterDefault_cfi |
It is a problem in cms-sw/cmssw#33802 for which I'll submit a fix soon. |
@cmsbuild, please test with cms-sw/cmssw#33802 |
Comparisons seem to be stuck, and I was thinking launching tests anyway from cmssw side now that code-checks there succeeded |
tested with cms-sw/cmssw#33802 |
+1 |
merge |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e2d8b/15762/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
A new release of mkfit is now available
https://github.com/trackreco/mkFit/releases/tag/V3.0.0-0%2Bpr315
this cmsdist PR still needs a matching PR in cms-sw/cmssw