Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT master - remove a commit to fix failure #6857

Merged
merged 2 commits into from
May 4, 2021

Conversation

mrodozov
Copy link
Contributor

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/rootmaster.

@smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14721/summary.html
COMMIT: 4ced5e2
CMSSW: CMSSW_12_0_ROOT6_X_2021-04-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6857/14721/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14721/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14721/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8523 step 2
136.8311 step 2
136.7611 step 2
136.88811 step 2
4.53 step 3
158.01 step 2
1325.81 step 2
136.731 step 3
136.793 step 3
136.874 step 3
135.4 step 3
1306.0 step 3
9.0 step 3
312.0 step 3
25.0 step 3
1330.0 step 3
10042.0 step 3
10824.0 step 3
10024.0 step 3
11634.0 step 3
25202.0 step 3
10224.0 step 3
12434.0 step 3
11634.911 step 3
23234.0 step 3
34634.0 step 3
28234.0 step 3
250202.181 step 4
34834.999 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 7596 lines to the logs
  • Reco comparison results: 1260 differences found in the comparisons
  • Reco comparison had 1 failed jobs
  • DQMHistoTests: Total files compared: 10
  • DQMHistoTests: Total histograms compared: 362210
  • DQMHistoTests: Total failures: 12922
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 349261
  • DQMHistoTests: Total skipped: 8
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.703 KiB( 9 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • Checked 119 log files, 14 edm output root files, 10 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor Author

please test

@mrodozov
Copy link
Contributor Author

abort
the comparison failed

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

Pull request #6857 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented May 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14790/summary.html
COMMIT: b02135a
CMSSW: CMSSW_12_0_ROOT6_X_2021-05-02-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6857/14790/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1267 differences found in the comparisons
  • Reco comparison had 1 failed jobs
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 3667
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2658938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.703 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor Author

mrodozov commented May 4, 2021

@slava77 this differences are present now also in the 6-24 test
are they reasonable/explicable/expected ? it's always this workflow

@smuzaffar
Copy link
Contributor

@mrodozov the differences are due to different input used for workflow 140.53. I would suggest to re run the tests

@mrodozov
Copy link
Contributor Author

mrodozov commented May 4, 2021

please test
ok lets

@slava77
Copy link
Contributor

slava77 commented May 4, 2021

@slava77 this differences are present now also in the 6-24 test
are they reasonable/explicable/expected ? it's always this workflow

ignoring 140.53, there are some unexpected points:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14837/summary.html
COMMIT: b02135a
CMSSW: CMSSW_12_0_ROOT6_X_2021-05-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6857/14837/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14837/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471dce/14837/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • Reco comparison had 1 failed jobs
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2662611
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 2ebfb22 into IB/CMSSW_12_0_X/rootmaster May 4, 2021
@slava77
Copy link
Contributor

slava77 commented May 4, 2021

there are some unexpected points:

and they were repeated in the latest test results

  • Reco comparison results: 14 differences found in the comparisons

  • Reco comparison had 1 failed jobs

It seems like the two ROOT versions are not quote compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants