Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for L1Trigger-TrackTrigger to V00-01-00 #6532

Merged

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jan 6, 2021

Move L1Trigger-TrackTrigger data to new tag, see
cms-data/L1Trigger-TrackTrigger#1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 6, 2021

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Jan 6, 2021

+externals

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 6, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 6, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c757e7/11988/summary.html
COMMIT: 2715bd5
CMSSW: CMSSW_11_3_X_2021-01-05-2300/slc7_amd64_gcc900

External Build

I found compilation warning when building: See details on the summary page.

@mrodozov
Copy link
Contributor

mrodozov commented Jan 6, 2021

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c757e7/11990/summary.html
COMMIT: 2715bd5
CMSSW: CMSSW_11_3_X_2021-01-05-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 7, 2021

Pull request #6532 was updated.

@silviodonato
Copy link
Contributor

solved conflict with #6534

@silviodonato
Copy link
Contributor

please test with cms-sw/cmssw#32574

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 7, 2021

Pull request #6532 was updated.

@mrodozov
Copy link
Contributor

mrodozov commented Jan 7, 2021

please test with cms-sw/cmssw#32574

@mrodozov
Copy link
Contributor

mrodozov commented Jan 7, 2021

sorry didn't realize this is still open :/

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 7, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c757e7/12003/summary.html
COMMIT: 8391f7a
CMSSW: CMSSW_11_3_X_2021-01-06-2300/slc7_amd64_gcc900

Build

I found compilation error when building:

>> Checking EDM Class Transients in libSimDataFormatsGEMDigiSimLink.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libSimDataFormatsHTXS.so
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/SimDataFormats/TrackerDigiSimLink/src/classes_def.xml in libSimDataFormatsTrackerDigiSimLink.so
error: class 'HepMC::HeavyIon' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 1386021189
Suggestion: You can run 'scram build updateclassversion' to generate src/SimDataFormats/GeneratorProducts/src/classes_def.xml.generated with updated ClassVersion
Error in : Dictionary trigger function for SimDataFormatsGeneratorProducts_xr not found
gmake: *** [tmp/slc7_amd64_gcc900/edm_checks/libSimDataFormatsGeneratorProducts.so] Error 1
>> Checking EDM Class Version for src/SimDataFormats/TrackingAnalysis/src/classes_def.xml in libSimDataFormatsTrackingAnalysis.so
TGenericClassInfo:0: RuntimeWarning: The rule for class: "HepMC::GenVertex": version, "[1-]" and data members: "m_id" has been skipped because the target member (m_id) is unknown.


@mrodozov
Copy link
Contributor

mrodozov commented Jan 8, 2021

test parameters:

@mrodozov
Copy link
Contributor

mrodozov commented Jan 8, 2021

please test

@tomalin
Copy link

tomalin commented Jan 8, 2021

Data in this PR will be used by C++ update to L1 tracking code cms-sw/cmssw#32574 , so hope this can be merged fairly soon.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c757e7/12017/summary.html
COMMIT: 8391f7a
CMSSW: CMSSW_11_3_X_2021-01-07-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 206
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716739
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@mrodozov mrodozov merged commit bd06f66 into IB/CMSSW_11_3_X/master Jan 8, 2021
@smuzaffar smuzaffar deleted the update-L1Trigger-TrackTrigger-to-V00-01-00 branch January 12, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants