add CLING_MODULEMAP_PATH to CLHEP tool #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
smuzaffar
reviewed
May 29, 2020
clhep-toolfile.spec
Outdated
| @@ -30,6 +30,7 @@ cat << \EOF_TOOLFILE >%i/etc/scram.d/clhepheader.xml | |||
| <runtime name="CLHEP_PARAM_PATH" value="$CLHEP_BASE"/> | |||
| <runtime name="CMSSW_FWLITE_INCLUDE_PATH" value="$INCLUDE" type="path"/> | |||
| <runtime name="ROOT_INCLUDE_PATH" value="$INCLUDE" type="path"/> | |||
| <runtime name="CLING_MODULEMAP_PATH" value="$PCM_UTIL_BASE/include" type="path"/> | |||
There was a problem hiding this comment.
@davidlange6 , can you please fix this? You need to use $CLHEP_BASE instead of $PCM_UTIL_BASE :-)
|
yes @davidlange6 this looks the right place |
|
Pull request #5888 was updated. |
|
fixed - I'll merge later if no one beats me to it. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #5888 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev identified this as missing from out last modules related changes.
@smuzaffar is this the right place to put the new envvar?