Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLING_MODULEMAP_PATH to CLHEP tool #5888

Merged
merged 3 commits into from
May 29, 2020

Conversation

davidlange6
Copy link
Contributor

@vgvassilev identified this as missing from out last modules related changes.
@smuzaffar is this the right place to put the new envvar?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@@ -30,6 +30,7 @@ cat << \EOF_TOOLFILE >%i/etc/scram.d/clhepheader.xml
<runtime name="CLHEP_PARAM_PATH" value="$CLHEP_BASE"/>
<runtime name="CMSSW_FWLITE_INCLUDE_PATH" value="$INCLUDE" type="path"/>
<runtime name="ROOT_INCLUDE_PATH" value="$INCLUDE" type="path"/>
<runtime name="CLING_MODULEMAP_PATH" value="$PCM_UTIL_BASE/include" type="path"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why PCM_UTIL_BASE ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 , can you please fix this? You need to use $CLHEP_BASE instead of $PCM_UTIL_BASE :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@smuzaffar
Copy link
Contributor

yes @davidlange6 this looks the right place

@cmsbuild
Copy link
Contributor

Pull request #5888 was updated.

@davidlange6
Copy link
Contributor Author

fixed - I'll merge later if no one beats me to it.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6693/console Started: 2020/05/29 17:43

@cmsbuild
Copy link
Contributor

Pull request #5888 was updated.

@smuzaffar smuzaffar merged commit 40bea93 into IB/CMSSW_11_2_X/rootmodule May 29, 2020
@smuzaffar smuzaffar deleted the davidlange6-patch-1 branch June 3, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants