Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root on cmsdist/rootmodule #5381

Conversation

mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3643/console Started: 2019/11/26 14:49

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov mrodozov changed the title Update ROOT module branch Update root on cmsdist/rootmodule Nov 26, 2019
@cmsbuild
Copy link
Contributor

-1

Tested at: 52daf2c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-284c5f/3643/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/EmissionVetoHook1.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc 
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory
 #include "Vincia/Vincia.h"
          ^~~~~~~~~~~~~~~~~
compilation terminated.
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory
 #include "Vincia/Vincia.h"


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@davidlange6
Copy link
Contributor

I guess this error has nothing to do with root... is it worth rerunning or is there an error in the IB?

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 27, 2019 via email

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 27, 2019 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3661/console Started: 2019/11/27 10:00

@smuzaffar
Copy link
Contributor

+externals
external builds and cmssw builds. Lets merge it and start an IB (this only effects CXXMODULES IBs)

@smuzaffar smuzaffar merged commit 76c615b into cms-sw:IB/CMSSW_11_0_X/rootmodule Nov 27, 2019
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/rootmodule IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 27, 2019 via email

@cmsbuild
Copy link
Contributor

-1

Tested at: 52daf2c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-284c5f/3661/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerFWCoreTFWLiteSelector had ERRORS
---> test materialBudgetTrackerPlots had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-284c5f/3661/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants