-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update root on cmsdist/rootmodule #5381
Update root on cmsdist/rootmodule #5381
Conversation
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
-1 Tested at: 52daf2c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/EmissionVetoHook1.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory #include "Vincia/Vincia.h" ^~~~~~~~~~~~~~~~~ compilation terminated. /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_CXXMODULE_X_2019-11-21-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:10: fatal error: Vincia/Vincia.h: No such file or directory #include "Vincia/Vincia.h" |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
I guess this error has nothing to do with root... is it worth rerunning or is there an error in the IB? |
Ok, yes its a IB issue.
On Nov 27, 2019, at 9:50 AM, David Lange <[email protected]<mailto:[email protected]>> wrote:
I guess this error has nothing to do with root... is it worth rerunning or is there an error in the IB?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#5381?email_source=notifications&email_token=ABGPFQZ2TA4DBCRUUCMZ4LDQVYYEHA5CNFSM4JRYH522YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIYIFY#issuecomment-558990359>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2V55L5ZKG672ZRDDDQVYYEHANCNFSM4JRYH52Q>.
|
please test
On Nov 27, 2019, at 9:50 AM, David Lange <[email protected]<mailto:[email protected]>> wrote:
I guess this error has nothing to do with root... is it worth rerunning or is there an error in the IB?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#5381?email_source=notifications&email_token=ABGPFQZ2TA4DBCRUUCMZ4LDQVYYEHA5CNFSM4JRYH522YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIYIFY#issuecomment-558990359>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2V55L5ZKG672ZRDDDQVYYEHANCNFSM4JRYH52Q>.
|
The tests are being triggered in jenkins. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/rootmodule IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Thx @smuzaffar
On Nov 27, 2019, at 4:44 PM, Malik Shahzad Muzaffar <[email protected]<mailto:[email protected]>> wrote:
+externals
external builds and cmssw builds. Lets merge it and start an IB (this only effects CXXMODULES IBs)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#5381?email_source=notifications&email_token=ABGPFQ644PAQ3Y37WBCPRS3QV2IWZA5CNFSM4JRYH522YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJ5F7I#issuecomment-559141629>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ73YQXSJUKND4UH3VTQV2IWZANCNFSM4JRYH52Q>.
|
-1 Tested at: 52daf2c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestRunnerFWCoreTFWLiteSelector had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test