-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rivet3 gcc820 #5160
Rivet3 gcc820 #5160
Conversation
This reverts commit 2dd3aa2.
A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_0_X/gcc820. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
I know where it was going wrong - didn't have fastjet contrib . The problem however started becoming more complex when the last cmsdist PR I tried didn't have cmssw IB to test against but the one from aug 12, which is without the rivet interface adjustments. Now the latest IB is with the adjustments so I hope this PR will build |
Comparison job queued. |
@mrodozov @intrepid42 for my understanding, if the problem is from missing headers why does this appear for gcc8 and gcc9 only, and we haven't broken the main gcc7 IB? |
Yes, the forward port merge failed for gcc8 and gcc9 in which case usually the .spec on gcc700 is not the same as on the branches it tries to auto merge. What we usually do is to keep the external as it was when it fails to auto merge which is what I tried but in this case also the cmssw interface changes and this doesn't work . And now I have to fix also the gcc9 external :) |
Comparison is ready Comparison Summary:
|
@mrodozov I understand that the comparison is made against the gcc7 build, this would explain the large number of differences. Apart for this it looks ok |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc820 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@fabiocos I just built these packages using gcc820 without problem:
Can you start a test here, please, so that I can see where it goes wrong? Otherwise, I need the logs of the failed builds.