-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --maxmem_profile to all runTheMatrix workflows to log mamimum memory allocated #2185
Conversation
A new Pull Request was created by @gartung for branch master. @cmsbuild, @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
(this PR is more about cms-sw/framework-team#829) |
I think there are some test flavors for which this monitoring would be harmful (like UBSAN, ASAN, |
Pull request #2185 was updated. |
REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#44001, please check if they should be merged together |
cms-sw/cmssw#44001 has been merged. |
Maybe we wait for Shahzad to get back to decide how exactly to continue (unless @aandvalenzuela @iarspider would know on the top of their head what exactly would need to be done to achieve #2185 (comment)). |
@@ -49,6 +49,7 @@ pushd "$WORKSPACE/matrix-results" | |||
case "${TEST_FLAVOR}" in | |||
gpu ) MATRIX_ARGS="-w gpu ${MATRIX_ARGS}" ;; | |||
high_stats ) CMD_OPTS="-n 500" ; MATRIX_ARGS="-i all ${MATRIX_ARGS}" ;; | |||
maxmem_profile ) CMD_OPTS="--maxmem_profile" ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gartung , is --maxmem_profile
supported by all cmssw release cycles? If not then I would suggest to run runTheMatrix.py --help
to see if this opt is supported or not. I n case a cmssw release cycle does not support it then just mark the commit status successfull with message Memory profile not run due to lack of support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
--maxmem_profile
supported by all cmssw release cycles?
It is not. The option was added in 14_1_X by cms-sw/cmssw#44001 .
Patrick is on a leave, so someone else would have to continue from here. I could do that, but I'd need guidance how to achieve #2185 (comment) .
So remind me what we want to do with this change? from the change it looks like we want to run extra relvals with |
I want all normal relval on x86 (only) to be run with |
I think we can close this PR in favor of #2202 |
@cmsbuild, please close |
addresses cms-sw/framework-team#829
requires cms-sw/cmssw#44001