Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AOT tools #10

Merged
merged 51 commits into from
Nov 16, 2023
Merged

Add AOT tools #10

merged 51 commits into from
Nov 16, 2023

Conversation

riga
Copy link
Member

@riga riga commented Nov 15, 2023

I'm opening this PR for @Bogdan-Wiederspan who did the actual code prototyping and implementation in this PR. However, we needed access to the CI pipelines, which is why the feature branch is not part of his fork but already in the main repo.


This PR adds all tools necessary

  • to inspect graphs regarding their AOT/XLA compatibility,
  • to specialize signatures of SavedModels (reading a graph with batching support from a SavedModel and converting it to one or more graphs that each have a fixed batch size), and
  • to AOT compile this specialized graphs.

New unit tests are provided along with docstrings for all new helpers.

Besides these additions, a few minor changes to existing code are provided, mostly to align the existing tensorflow tools to python 3.

Once merged, we should

  • release a new tag, perhaps 0.2.0,
  • publish to pypi, and
  • update the main cmsml documentation.

@valsdav

Bogdan W and others added 30 commits December 1, 2022 13:07
@riga riga added the improvement Improvement of existing functionality label Nov 15, 2023
@riga riga marked this pull request as draft November 15, 2023 15:40
@riga riga self-assigned this Nov 15, 2023
@riga riga marked this pull request as ready for review November 15, 2023 17:59
@riga riga requested a review from valsdav November 15, 2023 18:04
@valsdav
Copy link
Contributor

valsdav commented Nov 16, 2023

Hi @riga @Bogdan-Wiederspan , thanks a lot for the PR and for including all the tests and documetation.

I can tag the repository, but I guess you have the credentials for the update to pypi, right?

@riga riga merged commit 403d57e into master Nov 16, 2023
11 checks passed
@riga riga deleted the aot_helpers branch November 16, 2023 10:28
@valsdav
Copy link
Contributor

valsdav commented Nov 16, 2023

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants