Revert NN tau variable mapping

[HaarigerHarald]

Fixes #1237

[artlbv]

I tested it and it worked fine.

Please merge this ASAP as others can't use the IB.. @aloeliger @epalencia

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -j 8

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 check-headers

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

• L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b runtests

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!| Info | Value |
|:---------:|:------------:|
|return code|1|
|command|eval scramv1 runtime -sh && runTheMatrix.py --what upgrade -l 26834.78|

[aloeliger]

Hmm. The script output is wrong, but the return code is wrong. Let me check.

[aloeliger]

HLT overlap. Not this PR's issue.

[aloeliger]

@artlbv I am merging this PR.

@HaarigerHarald Could you please open a PR for this to CMSSW as soon as practical?

[artlbv]

thanks @aloeliger

on

@HaarigerHarald Could you please open a PR for this to CMSSW as soon as practical?

this should be really included in the same PR as #1225 (comment) so more for @Duchstf

[Duchstf]

@artlbv Hello, since it was #1225 was merged, how should I proceed? do I need to create a PR?

[artlbv]

@Duchstf actually you probably should not do anything.. the P2GT emulator has not been updated in central yet. the PR is on hold: #1207

[aloeliger]

I really don't want to lose either of these PRs to forgetfulness because we were all so busy with other phase 2 things. We should either:

1. Revert this and Correlator PuppiTauNN interface with GT.  #1225 and immediately reopen a revert-revert to remind us that this is going to go in
2. Merge this and Correlator PuppiTauNN interface with GT.  #1225 in a mini-update to CMSSW immediately.

This fork is only a convenience. Getting it in CMSSW is what actually matters.

[artlbv]

1. is the way to go..
2. will break the current P2GT emulator as it parses the Tau "isolation" for the ID: https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0_pre3/L1Trigger/Phase2L1GT/python/l1tGTMenu_lepSeeds_cff.py#L395 and fixing this will require the above P2GT PR in CMSSW

[HaarigerHarald]

Why not open a PR to central that basically includes both #1225 and #1238 ?

[aloeliger]

@HaarigerHarald @Duchstf Ping again on opening a PR to CMSSW combining #1225 and #1238. Please do not lose these changes.

[HaarigerHarald]

@Duchstf pls do it as it mostly concerns stuff in the correlator package. You can cherry-pick my commit into your branch and then just open a PR from it.

Edit: I opened a PR now