-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert NN tau variable mapping #1238
Revert NN tau variable mapping #1238
Conversation
I tested it and it worked fine. Please merge this ASAP as others can't use the IB.. @aloeliger @epalencia |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 1 files that did not meet formatting requirements:
Please run
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. This PR passes available unit tests!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation I found a non-zero return code running the relval workflows for this PR!| Info | Value | |
Hmm. The script output is wrong, but the return code is wrong. Let me check. |
HLT overlap. Not this PR's issue. |
@artlbv I am merging this PR. @HaarigerHarald Could you please open a PR for this to CMSSW as soon as practical? |
thanks @aloeliger on
this should be really included in the same PR as #1225 (comment) so more for @Duchstf |
I really don't want to lose either of these PRs to forgetfulness because we were all so busy with other phase 2 things. We should either:
This fork is only a convenience. Getting it in CMSSW is what actually matters. |
|
@HaarigerHarald @Duchstf Ping again on opening a PR to CMSSW combining #1225 and #1238. Please do not lose these changes. |
@Duchstf pls do it as it mostly concerns stuff in the correlator package. You can cherry-pick my commit into your branch and then just open a PR from it. Edit: I opened a PR now |
Fixes #1237