Fix errors in standalone compilation #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
compiler_errors
branch
from
c014561
to
7ec9637
Compare
|
Hi @anigamova ! Can this also be part of the v1.0 release? Or preferably just merged now. It's a harmless change, but important for compatibility. |
This is needed for standalone compilation, and can be done everywhere without breaking CMSSW compatibility (except for in `src/classes.h`).
This fixes compilation with more pedantinc compilers: even though the `RandStartPtr` was declared as a friend class, it uses the `MultiDimFit::GridType` in its public interface. This is not allowed.
guitargeek
force-pushed
the
compiler_errors
branch
from
7ec9637
to
14123c4
Compare
|
thanks @guitargeek! yes I think we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes remaining problems with the standalone compilation.