Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use override keyword were necessary #948

Merged
merged 3 commits into from
Jun 7, 2024

Commits on Apr 18, 2024

  1. Use override keyword were necessary

    To avoid future mistakes when overriding functions, this commit suggests
    to use the `override` keyword as suggested by clang-tidy.
    
    How this commit was produced:
    
    1. Compile with CMake, exporting the compile commands as described here:
       https://stackoverflow.com/questions/20059670/how-to-use-cmake-export-compile-commands
    
    2. Build
    
    3. Run this in the build directory:
       ```
       run-clang-tidy -header-filter="interface/.*" -config-file=../.clang-tidy -export-fixes
     fixes.yaml . -j20
       ```
    
    4. Copy the `fixes.yaml` back to the main repo and apply fixes with:
       ```
       clang-apply-replacements .
       ```
    
    5. Replace `ClassDef` macros with `ClassDefOverride` to be consistent.
    guitargeek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fa36dd4 View commit details
    Browse the repository at this point in the history
  2. Sustainable fix for getParameters signature change problem

    Follows up on `91b791a`, making sure that only the right overload is
    implemented.
    
    Also, apply the same fix to the `CachingAddNLL` class.
    guitargeek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bcbec56 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    3becf26 View commit details
    Browse the repository at this point in the history