Avoid using deprecated RooDataSet constructor #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @guitargeek! I guess with ROOT < 6.32 it is not going to work, right? Should we add if statements and use the new constructors with ROOT version starting with 6.32? |
|
It will work with any Root version. It was confusing to users which constructor they should actually use, hence ROOT 6.32 deprecated several redundant constructors. |
|
ah, ok, from the documentation of the earlier version it is not that clear indeed, thanks! |
The RooDataSet constructor that takes a weight variable name was deprecated in ROOT 6.32: root-project/root#14317 The general command argument constructor should be used, which doesn't change the functionality and is also backwards compatible with older ROOT versions. Also, avoid a unused variable warning.
guitargeek
force-pushed
the
ROOT_632_warnings
branch
from
b0724c0
to
654cde1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RooDataSet constructor that takes a weight variable name was deprecated in ROOT 6.32:
root-project/root#14317
The general command argument constructor should be used, which doesn't change the functionality and is also backwards compatible with older ROOT versions.
Also, avoid a unused variable warning.