Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header auth fix #183

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Header auth fix #183

merged 3 commits into from
Dec 4, 2024

Conversation

albinmedoc
Copy link
Contributor

In the last PR #180, the environment variable to enable header authentication was wrong. I have now fixed that.

Sign out doesn't work when using proxy auth since the user will immediately log back in (using the headers). So I have removed the sign out button from the menu.

Copy link
Owner

@cmintey cmintey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Good idea to move it to the locals anyways in case it's needed elsewhere

@cmintey cmintey merged commit 9738644 into cmintey:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants