-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Laravel 5.8 support #313
Conversation
@cmgmyr check this out! 😉 |
From Travis CI I've removed Do we need PHP nightly in build? It's failing all the time. |
Thank you! :-) hoping for a quick merge. |
@antonkomarev in your estimation, what is the likelyhood that this will be merged anytime soon? I am considering to fork it and merge your PR from here :-) |
@oad-dwarf I've pinged Chris on Twitter. Hope it will be merged soon. |
Thanks for the work @antonkomarev! This has been tagged |
It seems that I've missed one thing, that for Immutable dates we will need to use new |
I'd like to hold off on that for a while. I think we should actively support the last 2-3 latest Laravel releases. |
@cmgmyr yeah, if anybody will really need to have Immutable Dates - he always can overwrite default model. |
Closes #312
This PR adds:
Additionally it sets minimum version of PHP 7.1.3 as all new Laravel versions has, because Laravel 5.8 MUST have methods with
void
return type and it's allowed only since PHP 7.1.All versions below Laravel 5.5 cannot be supported because Illuminate\Support\Carbon has appeared only since v5.5.