Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 5.8 support #313

Merged
merged 4 commits into from
Mar 10, 2019
Merged

Conversation

antonkomarev
Copy link
Contributor

Closes #312

This PR adds:

  • Laravel 5.8 support
  • Allows to use Carbon 2.0 as well as Carbon 1.0

Additionally it sets minimum version of PHP 7.1.3 as all new Laravel versions has, because Laravel 5.8 MUST have methods with void return type and it's allowed only since PHP 7.1.

All versions below Laravel 5.5 cannot be supported because Illuminate\Support\Carbon has appeared only since v5.5.

@antonkomarev antonkomarev changed the title Add/laravel 58 support Add Laravel 5.8 support Feb 27, 2019
@antonkomarev
Copy link
Contributor Author

@cmgmyr check this out! 😉

@antonkomarev
Copy link
Contributor Author

antonkomarev commented Feb 27, 2019

From Travis CI I've removed sudo: false and PHP versions below 7.1 and added PHP 7.3.

Do we need PHP nightly in build? It's failing all the time.

@odinns
Copy link

odinns commented Feb 28, 2019

Thank you! :-) hoping for a quick merge.

@odinns
Copy link

odinns commented Mar 6, 2019

@antonkomarev in your estimation, what is the likelyhood that this will be merged anytime soon?

I am considering to fork it and merge your PR from here :-)

@antonkomarev
Copy link
Contributor Author

antonkomarev commented Mar 6, 2019

@oad-dwarf I've pinged Chris on Twitter. Hope it will be merged soon.

@cmgmyr cmgmyr merged commit 42dc58e into cmgmyr:master Mar 10, 2019
@cmgmyr
Copy link
Owner

cmgmyr commented Mar 10, 2019

Thanks for the work @antonkomarev! This has been tagged 2.17

@antonkomarev antonkomarev deleted the add/laravel-58-support branch March 17, 2019 08:45
@antonkomarev
Copy link
Contributor Author

It seems that I've missed one thing, that for Immutable dates we will need to use new Date facade, but these changes will require to drop all the Laravel versions before 5.8.
I'm not sure that we need to do it right now.

@cmgmyr
Copy link
Owner

cmgmyr commented Mar 18, 2019

I'd like to hold off on that for a while. I think we should actively support the last 2-3 latest Laravel releases.

@antonkomarev
Copy link
Contributor Author

@cmgmyr yeah, if anybody will really need to have Immutable Dates - he always can overwrite default model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants