Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for docs only mode #25

Closed
wants to merge 2 commits into from
Closed

Add fix for docs only mode #25

wants to merge 2 commits into from

Conversation

Techassi
Copy link

Fixes #21

@cmfcmf
Copy link
Owner

cmfcmf commented Dec 26, 2020

Thank you for this PR 👍
I've now looked into this bug myself and might have found a different solution that involves setting the existing docsRouteBasePath plugin option to /.
After fixing a bug that occurred when setting the option to just / in e76534b, docs-only mode should work just fine when passing { docsRouteBasePath: '/' } as options. Could you verify whether setting { docsRouteBasePath: '/' } in conjunction with e76534b fixes the problem for you? If so, I'd then go ahead and release v0.4.1.
I have released version 0.5.0 that includes the fix.

@cmfcmf
Copy link
Owner

cmfcmf commented Dec 26, 2020

Also notifying @franciscojaramillo - see my comment above, the problem should be fixed in version 0.5.0 when correctly setting the docsRouteBasePath.

@Techassi
Copy link
Author

Will check it out!

@Techassi
Copy link
Author

Techassi commented Dec 27, 2020

Works without any problems. Closing.
Thank you @cmfcmf

@Techassi Techassi closed this Dec 27, 2020
@Techassi Techassi deleted the docs-only-mode branch December 27, 2020 15:46
@franciscojaramillo
Copy link

Awesome, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs-only mode not working
3 participants