Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin breaks on docusaurus canary from refactored theme translation api #82

Closed
duanwilliam opened this issue Dec 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@duanwilliam
Copy link
Contributor

Bug description

facebook/docusaurus#5849 refactors the theme translation api and moves
the readDefaultCodeTranslationMessages function, used in this plugin, from @docusaurus/utils into a separate package, @docusaurus/theme-translations. This should probably be updated when Docusaurus get its next stable release in 2.0.0-beta.10.

Reproduction

try yarn start on canary build (not sure which one corresponds with the breaking pr but tested on 0.0.0-4248).

Environment

Package Versions

├─ @cmfcmf/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
├─ @docusaurus/[email protected]
└─ @docusaurus/[email protected]

Node Version

v14.15.0

Docusaurus Environment

  • using preset-classic
  • plugin config: [require.resolve('@cmfcmf/docusaurus-search-local'), {}]

Additional context

@duanwilliam duanwilliam added the bug Something isn't working label Dec 6, 2021
@Josh-Cena
Copy link
Contributor

@cmfcmf I'm encountering the same issue. In fact I'm encountering lots of pain points while using this plugin. As a Docusaurus maintainer myself, may I ask you to kindly give me write permissions so I can help modernize this plugin and make it more aligned with the core's style & conventions?

@cmfcmf
Copy link
Owner

cmfcmf commented Dec 10, 2021

Thank you @duanwilliam for reporting this! I am currently blocked on missing type definitions for @docusaurus/theme-translations, see facebook/docusaurus#6087.

@Josh-Cena I welcome contributions. Please feel free to open issues and/or pull requests. I have spent a lot of time last weekend to catch up with the latest Docusaurus development, but as you say, there is still stuff to do.

cmfcmf added a commit that referenced this issue Dec 11, 2021
cmfcmf added a commit that referenced this issue Dec 11, 2021
BREAKING CHANGE: the minimum supported Docusaurus version is now v2.0.0-beta9.

Fixes #82
Fixes #83
@cmfcmf cmfcmf closed this as completed in e74750f Dec 11, 2021
@cmfcmf
Copy link
Owner

cmfcmf commented Dec 11, 2021

Should be fixed in v0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants