Skip to content
This repository has been archived by the owner on May 12, 2023. It is now read-only.

Include state in auth url #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Include state in auth url #17

wants to merge 2 commits into from

Conversation

peterchaula
Copy link

It seems like if you follow Shopify OAuth Documentation and include the state parameter for verification the hmac verification fails on the client server size. My assumption is that Shopify includes state in calculation of the hash

https://{shop}.myshopify.com/admin/oauth/authorize?client_id={api_key}&scope={scopes}&redirect_uri={redirect_uri}&state={nonce}

{nonce} - a randomly selected value provided by your application, which is unique for each authorization request. During the OAuth >callback phase, your application must check that this value matches the one you provided during authorization. This mechanism is >important for the security of your application.

Shopify docs

It seems like if you follow Shopify OAuth Documentation and include the **state** parameter for verification the **hmac** verification fails on the client server size. My assumption is that Shopify includes **state** in calculation  of the hash

>https://{shop}.myshopify.com/admin/oauth/authorize?client_id={api_key}&scope={scopes}&redirect_uri={redirect_uri}&state={nonce} 

>{nonce} - a randomly selected value provided by your application, which is unique for each authorization request. During the OAuth >callback phase, your application must check that this value matches the one you provided during authorization. This mechanism is >important for the security of your application.

[Shopify docs](https://help.shopify.com/api/guides/authentication/oauth#scopes)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant