Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed EventedMind/iron-router#606 , UI.body.events #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nerdmed
Copy link

@nerdmed nerdmed commented Apr 21, 2014

This seems like the missing part, i dont think this has any bad side effects? What do you think @cmather?

@@ -363,7 +363,9 @@ BlazeUIManager = function (router) {

BlazeUIManager.prototype = {
render: function (props, parentComponent) {
this._component = UI.render(Layout.extend(props || {}), parentComponent || UI.body);
// Layout extending UI.body to get into the lookup chain for events
var bodyLayout = UI.body.extend(Layout);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does inheriting from UI.body cause UI.body events to be handled from the layout?

@nerdmed
Copy link
Author

nerdmed commented Apr 28, 2014

Excellent question - i started following the path on a click event. Honestly i cant really understand how the DomRange works by reading the source code. But as soon as you extend a Component its changing the behaviour of the DomRange structure. This Event delegating thing is really quite complex. I found a lot of hints that forced me to try this approach. Would be to much to share my whole chaotic path through DomRange. Would be great to hear something from someone quite experienced with the DomRange :/ if my testing enviroment could help you i can share it.

webcrx added a commit to webcrx/blaze-layout that referenced this pull request May 16, 2014
@DenisGorbachev
Copy link

UI.body.events aren't firing for me, too. Would be great to see this fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants