Add routes and marker functionality #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DLintott I know we don't always strictly follow WP coding standards, but I'm trying to convert to it (gradually). I'm going to do some minor formatting on your PR before merging it. Most of all - THANK YOU!!! |
|
@jrfoell Cheers! Haven't really done much WP plugin coding before, so haven't really looked at the standards before.. so just tried to stick with what was already there. |
|
@DLintott do you have a WP.org profile name that you use for development or support? I'd love to give you a shout-out and I can also add you to our plugin contributors list 👍 |
|
@jrfoell I didn't have one.... but I do now! Same name as on here.... dlintott 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a routes shortcode, to enable displaying a route from Strava in the same way activities are displayed.
I have also added an option to display markers at the start and finish points of the route or activity. This defaults to false to preserve backwards compatibility fro users upgrading their plugin