SD2: Add Hodir updates to sd2.sql #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerwife
reviewed
Nov 10, 2024
sql/scriptdev2/scriptdev2.sql
Outdated
| UPDATE `creature_template` SET `AIName`='', `ScriptName`='npc_snowpack_target' WHERE `Entry`=33174; | ||
| UPDATE `creature_template` SET `AIName`='EventAI', `ScriptName` = '' WHERE `Entry` = 33169; -- Icicle | ||
| -- Hodir's Helper NPCs | ||
| UPDATE `creature_template` SET `StringId1`=6030701 WHERE `entry` IN (32941, 33333, 32950, 33332, 32946, 33331, 32948, 33330, 32901, 33325, 32900, 33328, 32893, 33327, 32897, 33326, 33342); |
There was a problem hiding this comment.
only scriptname goes here. All the rest of the sql goes to db.
And if script is set, ai name is overriden so you dont need to do that.
There was a problem hiding this comment.
is there a reason why it's fragmented like this? I'll change it ofc, I'm just curious
There was a problem hiding this comment.
Yes, after a long discussion with cyberium we are trying to remove almost all sql from core, except script assignments to respective entries until a point in time when spell and other refactoring is reaching critical mass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR implements the requests of Grz3s of moving data from the DB repo to the Core repo