StaticFlags: Implement NO_MELEE_APPROACH #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could also mean the exact opposite: Melee combat is disabled, but the Creature tries to run into melee range, similar to NO_MELEE_FLEE except it approaches instead of flees. I'm not sure |
|
The proper name of this flag is
Cataclysm has one https://www.wowhead.com/npc=40168/corrupted-dryad |
|
Thanks a lot, I'll update the code! |
killerwife
reviewed
Oct 6, 2024
src/game/AI/BaseAI/CreatureAI.cpp
Outdated
| @@ -35,6 +35,7 @@ CreatureAI::CreatureAI(Creature* creature, uint32 combatActions) : | |||
| { | |||
| m_dismountOnAggro = !(m_creature->GetCreatureInfo()->CreatureTypeFlags & CREATURE_TYPEFLAGS_MOUNTED_COMBAT); | |||
| SetMeleeEnabled(!m_creature->GetSettings().HasFlag(CreatureStaticFlags::NO_MELEE_FLEE)); | |||
| SetMeleeEnabled(!m_creature->GetSettings().HasFlag(CreatureStaticFlags4::NO_MELEE_APPROACH)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR implements CreatureStaticFlags4::NO_MELEE_APPROACH