-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Chat support #668
base: master
Are you sure you want to change the base?
Voice Chat support #668
Conversation
- Group/raid/bg channels are added automatically - Custom channels are added when someone with voice chat enabled joins it or by right click in chat UI - Group leaders/Channel owners can mute others in channel, though it doesn't persist if someone leaves channel e.g. relogs - Can mute other players similar to ignore - VoiceChat server is a separate app that receives/sends voice UDP packets from clients - VoiceChat server is the one made by Ascent developers, just with couple new opcodes - VoiceChat server is fetched by cmake from celguar/voicechat-server - There is support for reconnecting to voice server while server is running
wow, just WOW |
amazing! |
I just want to make sure you know, me and cyberium talked about merging this and we kinda agree it should be merged, but it will require the attention of one of us. I do not want to make any promises, however once I am done processing my tbc data I gathered, I will look at it. (estimating 2-3 months from now) Obviously if someone else picks it up and reviews/fixes any design issues, no problem there. I just kinda swamped myself with the whole wotlk going away. |
flags_unk = 0x80; | ||
} | ||
|
||
ObjectGuid m_guid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client names are MemberGUID, NetworkId, Flags and for unk it's Priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate
🍰 Voice Chat
Info
What is Voice Chat
Core changes
VoiceChat server
Demonstration
Todo / Checklist
I don't expect this PR to be merged anytime soon, just made it because I did what I could at this point and want to share