Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust extractor scripts #519

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dwyriel
Copy link
Contributor

@Dwyriel Dwyriel commented Sep 29, 2023

🍰 Pullrequest

Changed how the arguments passed to the executables (ad, vmap_extractor, etc) are prepared, so the script can accept client and output paths containing white-spaces.
Added a check to halt execution if ad had an error, as to not proceed to MoveMapGen.sh if map files were not properly extracted.
Formatted both scripts using shfmt -i 2 to keep indentation consistent and making the scripts easier to read.

All changes were tested in dash and bash.

Todo

  • (Optionally) Check exit code of MoveMapGen to know if it was executed properly.

Other small changes:
1 - Fix check of output mmap folder before attempting to create it.
2 - Moved the wait call to be right after the sub-shell execution
3 - Changed a few pipes to tee to be output redirection instead to not cause double logging to the terminal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant