Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorials/iperf3: Add CRD description for each command #483

Merged
merged 1 commit into from
Apr 3, 2024
Merged

tutorials/iperf3: Add CRD description for each command #483

merged 1 commit into from
Apr 3, 2024

Conversation

kfirtoledo
Copy link
Collaborator

@kfirtoledo kfirtoledo commented Apr 2, 2024 •
edited
Loading

@kfirtoledo kfirtoledo added the documentation Improvements or additions to documentation label Apr 2, 2024
orozery
orozery reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@orozery orozery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment:
I think we should use CR (and not CRD) when referring to objects like Import, Export, etc.

elevran
elevran approved these changes Apr 3, 2024
View reviewed changes
website/content/en/docs/tutorials/iperf.md Outdated Show resolved Hide resolved
website/content/en/docs/tutorials/iperf.md Outdated Show resolved Hide resolved
website/content/en/docs/tutorials/iperf.md Show resolved Hide resolved
website/content/en/docs/tutorials/iperf.md Outdated Show resolved Hide resolved
website/content/en/docs/tutorials/iperf.md Outdated Show resolved Hide resolved
@kfirtoledo kfirtoledo merged commit 85573d4 into clusterlink-net:main Apr 3, 2024
9 checks passed
@kfirtoledo kfirtoledo deleted the iperf3 branch April 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orozery orozery orozery left review comments

@elevran elevran elevran approved these changes

@michalmalka michalmalka Awaiting requested review from michalmalka michalmalka is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfirtoledo @elevran @orozery