Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policyengine/PolicyDispatcher: allow to delete unprivileged policy #431

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

kfirtoledo
Copy link
Collaborator

Add delete unprivileged policy function,
(Delete privileged policy is still missing -can be done by adding finalizer before deleting to the policies or separate access policy CRDS to privileged and non-privileged)

Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an intermediate step towards deleting policies, which still tries to maintain backward compatibility.
Is it really worthwhile, or should we move directly to full CRD instance (allowing duplicate names across namespaces, same name for privileged and normal in the same namespace, etc.)?
Am ok approving if the next iteration of the change is already in the works and you're just breaking up the larger change into smaller changesets.
Also, not the test failure...

pkg/controlplane/authz/manager.go Outdated Show resolved Hide resolved
pkg/policyengine/PolicyDispatcher.go Outdated Show resolved Hide resolved
pkg/policyengine/PolicyDispatcher.go Outdated Show resolved Hide resolved
@elevran
Copy link
Collaborator

elevran commented Mar 26, 2024

for now, we'll support a single level of policies

@kfirtoledo kfirtoledo merged commit 9cb95d5 into clusterlink-net:main Mar 31, 2024
9 checks passed
@kfirtoledo kfirtoledo deleted the policy branch March 31, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants