cmd/deploy: Support ingress port flag #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevran
reviewed
Mar 10, 2024
elevran
reviewed
Mar 10, 2024
There was a problem hiding this comment.
what does it mean to deploy without a start?
What gets created, what doesn't? For example, is it only deploying the operator and then start lets you define the CRD to use?
If so, suggest splitting to deploy-operator and deploy-instance (conceptually, choose better command names obviously...)
elevran
approved these changes
Mar 10, 2024
Signed-off-by: Kfir Toledo <[email protected]>
Signed-off-by: Kfir Toledo <[email protected]>
Signed-off-by: Kfir Toledo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ingress port flag for the deploy peer command.