Fix documentation for $selected argument for radio and checkbox dialogs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,10 +183,12 @@ $builder->info($text, $title = null); | |||
| ```php | |||
| $builder->listCheck(array $list, $text = null, $selected = null); | |||
There was a problem hiding this comment.
$selected should be an array here.
Can you amend your change to explain why? Thanks!
There was a problem hiding this comment.
Do you prefer a new commit or an extra one?
There was a problem hiding this comment.
I think amending your previous commit makes most sense.
There was a problem hiding this comment.
I made the amend ;-)
There was a problem hiding this comment.
Are you sure you've pushed this? :-)
There was a problem hiding this comment.
Woops, forgot to git add before git commit --amend xD
clue
changed the title
bertvandepoel
force-pushed
the
doc_fix1
branch
2 times, most recently
from
32e7fe4 to
ec81ba0
Compare
|
Thanks, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.