Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in documentation #9

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix typos in documentation #9

merged 1 commit into from
Nov 22, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 14, 2023

This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of #7.

@clue I also had in mind your comment in clue/reactphp-flux#28 (comment) and in this project all whitespaces should be aligned correctly.

Refers to the changes of https://github.com/clue-access/reactphp-tsv/pull/16.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good 👍

This is the placeholder project for https://github.com/clue-access/reactphp-tsv, can you apply these changes there as well?

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Nov 14, 2023
@SimonFrings SimonFrings requested a review from clue November 14, 2023 15:48
@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 14, 2023

PR looks good 👍

This is the placeholder project for https://github.com/clue-access/reactphp-tsv, can you apply these changes there as well?

@SimonFrings alright this will be the next step for me since I joined clue·access today! Will be around in the next coming days. 🥳 Thank you.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, change LGTM! :shipit:

@clue clue merged commit 54c0302 into clue:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants