Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 8.3 and update test suite #106

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Run tests on PHP 8.3 and update test suite #106

merged 1 commit into from
Nov 28, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 24, 2023

This pull request builds on top of #103 #102 #101

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

@yadaiio yadaiio changed the title Run PHP 8.3 and update test suite Run tests on PHP 8.3 and update test suite Nov 24, 2023
SimonFrings
SimonFrings approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonFrings SimonFrings added this to the v2.7.0 milestone Nov 28, 2023
clue
clue approved these changes Nov 28, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit f7ebf4e into clue:2.x Nov 28, 2023
14 checks passed
@SimonFrings SimonFrings mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yadaiio @clue @SimonFrings