Forward compatibility with upcoming Promise v3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
changed the title
|
The first commit updates this to the currently unreleased Socket component to show how this only depends on reactphp/socket#214, clue/reactphp-socks#106 and friends-of-reactphp/mysql#157 (the build should be green). The second commit updates this to the releases that have yet to be tagged. This is expected to fail at the moment and should be green once the releases are tagged and the build is restarted. |
|
The HHVM run will currently fail due to composers new version. #36 will fix this issue by downgrading composer for the hhvm build. |
clue
changed the title
|
Updated now that Socket v1.12.0 and SOCKS v1.4.0 have been released, this is now ready for review (Unrelated HHVM build error has been fixed via #36 in the meantime) |
SimonFrings
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of clue/reactphp-socks#106, friends-of-reactphp/mysql#157, clue/reactphp-block#61 and reactphp/socket#214
Refs clue/reactphp-http-proxy#44