Merge pull request #38 from SimonFrings/sensitive_parameter

Mark passwords and URIs as `#[\SensitiveParameter]` (PHP 8.2+)
clue · Sep 2, 2022 · a33a624 · a33a624
2 parents d60a5d8 + 869a401
commit a33a624
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/SshProcessConnector.php b/src/SshProcessConnector.php
@@ -38,8 +38,11 @@ class SshProcessConnector implements ConnectorInterface
      * @param ?LoopInterface $loop
      * @throws \InvalidArgumentException
      */
-    public function __construct($uri, LoopInterface $loop = null)
-    {
+    public function __construct(
+        #[\SensitiveParameter]
+        $uri,
+        LoopInterface $loop = null
+    ) {
         // URI must use optional ssh:// scheme, must contain host and neither pass nor target must start with dash
         $parts = \parse_url((\strpos($uri, '://') === false ? 'ssh://' : '') . $uri);
         $pass = isset($parts['pass']) ? \rawurldecode($parts['pass']) : null;

diff --git a/src/SshSocksConnector.php b/src/SshSocksConnector.php
@@ -49,8 +49,11 @@ class SshSocksConnector implements ConnectorInterface
      * @param ?LoopInterface $loop
      * @throws \InvalidArgumentException
      */
-    public function __construct($uri, LoopInterface $loop = null)
-    {
+    public function __construct(
+        #[\SensitiveParameter]
+        $uri,
+        LoopInterface $loop = null
+    ) {
         // URI must use optional ssh:// scheme, must contain host and neither pass nor target must start with dash
         $parts = \parse_url((\strpos($uri, '://') === false ? 'ssh://' : '') . $uri);
         $pass = isset($parts['pass']) ? \rawurldecode($parts['pass']) : null;