Update test suite to remove deprecated utf8_decode() in preparation for PHP 8.2
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
changed the title
utf8_decode() in preparation for PHP 8.2utf8_decode() in preparation for PHP 8.2
clue
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
@SimonFrings Thank you for looking into this, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two methods
utf8_encode()andutf8_decode()will be marked as deprecated in PHP 8.2, will raise a standard E_DEPRECATED diagnostic, and will be removed in PHP 9. The tests now use the string that would ultimately come fromutf8_decode(), I don't expect that to change in the future due to the standardization of UTF8 and ISO 8859-1 (Latin-1).