Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP warnings due to lack of args in exception trace on PHP 7.4 #92

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

clue
Copy link
Owner

@clue clue commented Jun 15, 2020

Some installations of PHP 7.4 do not report the "args" in the exception trace anymore due to the new zend.exception_ignore_args INI setting. This can lead to reporting some PHP warnings (PHP Warning: Invalid argument supplied for foreach()) and/or rejected promises depending on the error handler used.

Accordingly, this didn't show up during unit tests because PHPUnit transforms these warnings into exceptions automatically which will cause the underlying promise to be rejected – which will not be reported by default (reactphp/promise#87). This can be best reproduced by running one of the examples with an invalid SOCKS proxy setup and error reporting enabled. This should now report a promise rejection without any PHP warnings.

Builds on top of clue/reactphp-http-proxy#33 and #82.

@clue clue added this to the v1.1.0 milestone Jun 15, 2020
@clue clue merged commit 5b7efb2 into clue:master Jun 15, 2020
@clue clue deleted the trace branch June 15, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant