Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creation of dynamic property (PHP 8.2+) #118

Merged
merged 1 commit into from
May 28, 2024

Conversation

clue
Copy link
Owner

@clue clue commented May 28, 2024

Builds on top of #108, #113 and reactphp/stream#53
Resolves / closes #114

@clue clue added this to the v1.5.0 milestone May 28, 2024
@clue clue requested a review from cassifyit May 28, 2024 11:07
@clue clue force-pushed the dynamic-properties branch from e637704 to 20f2df2 Compare May 28, 2024 12:38
Copy link
Collaborator

@cassifyit cassifyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @clue 👍

@cassifyit cassifyit merged commit d6c1311 into clue:1.x May 28, 2024
14 checks passed
@clue clue deleted the dynamic-properties branch May 28, 2024 12:43
@prakash
Copy link

prakash commented Nov 13, 2024

Is it possible to create a minor new release which include this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notice on php 8.2
3 participants