fiix php8 depreciation notice #61
Conversation
|
Hey @detain, thanks for opening this pull request. I'm a bit unclear about the deprecation notices you mentioned and how your changes will help. It would be really helpful for me and other reviewers to see the specific error messages and understand better what you're trying to improve. Just a heads up, the tests are currently not running green. Your changes are not the cause of this issue, as described in clue/reactphp-soap#58, because the website we are using for our test suite is currently down. Additionally, after talking with @clue and @SimonFrings about this, we have decided to address this in the future once we have identified the best approach for this. We are currently focusing on other priorities such as the ongoing development for Framework X and ReactPHP v3, so I will keep you updated once we will revisit this topic. If you need this feature urgently, you can also reach out to us or help us prioritizing by becoming a sponsor. ❤️ Thank you! For now I think it's best closing this until we have resolved #58 and add PHP 8 support afterwards. |
tests need to be updated