Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by supporting new default loop #56

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

clue
Copy link
Owner

@clue clue commented Aug 1, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$factory = new Clue\React\Quassel\Factory($loop);

// new (using default loop)
$factory = new Clue\React\Quassel\Factory();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232 and reactphp/socket#260
Also builds on top of #53 and #55 to skip tests that exhibit a rare race condition

@clue clue added this to the v0.8.0 milestone Aug 1, 2021
@clue clue force-pushed the default-loop branch 5 times, most recently from cafccda to ede0ce3 Compare August 1, 2021 14:31
@clue clue force-pushed the default-loop branch 2 times, most recently from dc1bf45 to f6c7973 Compare August 1, 2021 14:48
@clue clue merged commit 36e3972 into clue:master Aug 1, 2021
@clue clue deleted the default-loop branch August 1, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant