Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite by testing against PHP 7.2 and fix risky tests #37

Merged
merged 1 commit into from
May 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ php:
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm # ignore errors, see below

# lock distro so new future defaults will not break the build
Expand Down
3 changes: 3 additions & 0 deletions tests/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ public function setUp()
$this->client = new Client($this->stream, $this->protocol, $this->splitter);
}

/**
* @doesNotPerformAssertions
*/
public function testCtorOptionalArgs()
{
$this->stream = $this->getMockBuilder('React\Stream\DuplexStreamInterface')->getMock();
Expand Down
3 changes: 3 additions & 0 deletions tests/FactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ public function setUp()
$this->factory = new Factory($this->loop, $this->connector, $this->prober);
}

/**
* @doesNotPerformAssertions
*/
public function testCtorOptionalArgs()
{
new Factory($this->loop);
Expand Down
4 changes: 4 additions & 0 deletions tests/FunctionalTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public function setUp()
}
}

/**
* @doesNotPerformAssertions
*/
public function testCreateClient()
{
$factory = new Factory(self::$loop);
Expand Down Expand Up @@ -164,6 +167,7 @@ public function testWriteHeartBeatDefaultsToCurrentTime(Client $client)

/**
* @depends testCreateClient
* @doesNotPerformAssertions
*/
public function testClose(Client $client)
{
Expand Down