Merge pull request #29 from SimonFrings/decoder-types

Check type of incoming `data` before trying to decode NDJSON
clue · May 10, 2022 · a648565 · a648565
2 parents 5869138 + 5f0a150
commit a648565
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Decoder.php b/src/Decoder.php
@@ -99,6 +99,11 @@ public function pipe(WritableStreamInterface $dest, array $options = array())
     /** @internal */
     public function handleData($data)
     {
+        if (!\is_string($data)) {
+            $this->handleError(new \UnexpectedValueException('Expected stream to emit string, but got ' . \gettype($data)));
+            return;
+        }
+
         $this->buffer .= $data;
 
         // keep parsing while a newline has been found

diff --git a/tests/DecoderTest.php b/tests/DecoderTest.php
@@ -67,6 +67,14 @@ public function testEmitDataBigIntOptionWillForwardAsString()
         $this->input->emit('data', array("999888777666555444333222111000\n"));
     }
 
+    public function testEmitDataWithInvalidTypeWillForwardErrorWithUnexpectedValueException()
+    {
+        $this->decoder->on('data', $this->expectCallableNever());
+        $this->decoder->on('error', $this->expectCallableOnceWith($this->isInstanceOf('UnexpectedValueException')));
+
+        $this->input->emit('data', array(false));
+    }
+
     public function testEmitDataErrorWillForwardError()
     {
         $this->decoder->on('data', $this->expectCallableNever());