Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #22

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 17, 2024

This pull request builds on top of #17, #9 and #8.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me 👍

@SimonFrings SimonFrings added this to the v1.2.0 milestone Jan 18, 2024
@SimonFrings SimonFrings requested a review from clue January 18, 2024 08:24
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 30d4e53 into clue:master Jan 19, 2024
14 checks passed
@yadaiio yadaiio mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants